Repository navigation
Android: Fix not clickable via TalkBack - #1190
Conversation
|
Tested on 2.0.0 with RN 0.88 (New Architecture), Android 16 emulator: with this change, One thing to watch on Fabric: our trigger |
Naturalclar
left a comment
There was a problem hiding this comment.
Thanks! Forwarding the child's accessibility click to the menu is a clean fix for #1189. Normal taps are unaffected (onInterceptTouchEvent still takes every touch, and nothing else calls performClick()), and long-press mode is respected. CI is green against current master.
Follow-ups worth tracking separately (not blocking): menus with shouldOpenOnLongPress are still unreachable via TalkBack's long-press action, and the child's listener can be replaced by React Native's own setFocusable if that prop changes after mount.
Overview
Fixes #1189 by forwarding the child's click event to the parent menu.
The issue: The menu trigger isn't clickable via TalkBack (screen reader) on Android. You can select the menu button, but clicking it does nothing. It works fine without a screen reader, and on iOS with or without VoiceOver.
Test Plan
Without the fix:
With the fix: